Open
Conversation
lavrukov
force-pushed
the
tx-manager-tracer-2
branch
4 times, most recently
from
f330c02 to
5b47768
Compare
lavrukov
force-pushed
the
tx-manager-tracer-2
branch
from
5b47768 to
a40fcb2
Compare
nvamelichev
requested changes
Oct 18, 2025
| } | ||
| } | ||
| } catch (Exception e) { | ||
| tracer.onException(); |
Collaborator
There was a problem hiding this comment.
tracer.onException(e) will be more extensible
| } | ||
| } | ||
| results.labels(name, "fail").inc(); | ||
| tracer.onRetryExceeded(); |
Collaborator
There was a problem hiding this comment.
Same as onException(e), onRetryExceeded(e) will offer more extensibility
| import java.util.concurrent.atomic.AtomicReference; | ||
| import java.util.function.Supplier; | ||
|
|
||
| import static java.lang.String.format; |
Collaborator
There was a problem hiding this comment.
This import is unused, please remove it (Checkstyle)
| public ReadonlyBuilder withStatementIsolationLevel(IsolationLevel isolationLevel) { | ||
| Preconditions.checkArgument(isolationLevel.isReadOnly(), | ||
| "readOnly() can only be used with a read-only tx isolation level, but got: %s", isolationLevel); | ||
| "readOnly() can only be used with a read-only tx isolation level, but got: %s", isolationLevel |
Collaborator
There was a problem hiding this comment.
Minor whitespace change. I'd leave it as-is instead
| import java.util.function.Consumer; | ||
| import java.util.function.Supplier; | ||
|
|
||
| public interface StdTxManagerTracer { |
Collaborator
There was a problem hiding this comment.
Let's make the interface part of StdTxManagerTracer an interface inside StdTxManager, like TracerFactory.
And the Tracer implementations will be in separate class(es), as they are now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.